Enhancement #1
Open
Enhancement #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoyunhe
requested changes
Nov 18, 2019
| @@ -10,21 +10,26 @@ $flexbin-phone-max: 400px !default; | |||
| $flexbin-row-height-phone: 100px !default; | |||
| $flexbin-space-phone: $flexbin-space !default; | |||
|
|
|||
| $flexbin-add-end-space: false; | |||
There was a problem hiding this comment.
Every parameter should be optional, with !default. This option should be true by default to be backward compatible.
| // Minxin for customize multiple Flexbin layout | ||
| // For example, 300px height for desktop devices, 150px height for mobile devices | ||
| @mixin flexbin($row-height, $space) { | ||
| display: flex; | ||
| overflow: hidden; | ||
| flex-wrap: wrap; | ||
| margin: - $space / 2; | ||
| margin: 0 (-1 * $space / 2); | ||
| padding: 2.5px 0; |
There was a problem hiding this comment.
Please remove this padding. It is not designed like this.
| // Minxin for customize multiple Flexbin layout | ||
| // For example, 300px height for desktop devices, 150px height for mobile devices | ||
| @mixin flexbin($row-height, $space) { | ||
| display: flex; | ||
| overflow: hidden; | ||
| flex-wrap: wrap; | ||
| margin: - $space / 2; | ||
| margin: 0 (-1 * $space / 2); |
There was a problem hiding this comment.
You can define a local variable $container-margin: -1 * $space / 2; to make it easier to read. Note, this margin is same for all sides.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put 2 commits to enhance this library.
Thank you!