support relative lift in betamvtest #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alonme
commented
Aug 24, 2022
| xall = [p.get() for p in processes] | ||
| maxall = np.maximum.reduce(xall) | ||
|
|
||
| return (maxall / xvariant).mean() - 1 |
There was a problem hiding this comment.
Suggested change
| return (maxall / xvariant).mean() - 1 | |
| return (xvariant / maxall).mean() - 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @guillermo-navas-palencia,
in the
experiment_summaryfunction, theimprovementis defined as the negative relative loss.which means that it will be calculated in the following method
-1 * ((control - variant) / variant)which is the same as
(variant - control) / varianthowever i think it makes more sense to calculate improvement, or lift in the following manner
(variant - control) / control- as the change should be relative to the controli have added an implementation of this function for the betaMVtest.
What do you think?