Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support clickhouse db #36

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support clickhouse db #36

wants to merge 3 commits into from

Conversation

eskomorokhov
Copy link

Implementation to support clickhouse db throw clickhouse-driver. Tested manually with remote clickhouse db.

@wandenberg
Copy link
Collaborator

Hi @eskomorokhov would be pretty good to have tests to your code. Can you do that?
And take a look in the way we initiate/import the driver for the other databases.
The way you did it will require me to have the driver installed no matter if I will use it or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eskomorokhov @wandenberg