Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align API names with Constraint #63

Merged
merged 5 commits into from
Nov 22, 2024
Merged

align API names with Constraint #63

merged 5 commits into from
Nov 22, 2024

Conversation

mmoskal
Copy link
Collaborator

@mmoskal mmoskal commented Nov 22, 2024

No description provided.

@mmoskal mmoskal requested a review from hudson-ai November 22, 2024 01:39
@mmoskal mmoskal marked this pull request as ready for review November 22, 2024 01:39
hudson-ai
hudson-ai approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@hudson-ai hudson-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hudson-ai
Copy link
Collaborator

@mmoskal is commit_token returning None on the last call the only real semantic change here beyond renaming the methods?

@hudson-ai
Copy link
Collaborator

@lochuynh1412 pinging you for visibility

@mmoskal
Copy link
Collaborator Author

mmoskal commented Nov 22, 2024

I reverted the commit_token() change, since it was returning stop only in case compute_mask() already did (in which case we don't even call it); easier to keep it as it was

@mmoskal mmoskal merged commit e55998b into main Nov 22, 2024
2 checks passed
@mmoskal mmoskal deleted the new_api branch November 22, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudson-ai hudson-ai hudson-ai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmoskal @hudson-ai