Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test recursive nullable grammars #1026

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hudson-ai
Copy link
Collaborator

In the spirit of #1025 , this adds tests against a potentially degenerate case for the parser. This PR supersedes #874 which was designed for the old python parser.

Closes #863

@paulbkoch
Copy link
Collaborator

paulbkoch commented Sep 24, 2024

Very nice tests @hudson-ai. Looks like it's exposing a parser bug.

@hudson-ai
Copy link
Collaborator Author

Very nice tests @hudson-ai. Looks like it's exposing a parser bug.

Thanks Paul! I can't take credit for the tests -- got them from here ;)
I'm not entirely sure whether this really exposes a bug or if my test case isn't written quite correctly. Waiting on @mmoskal to have some bandwidth to take a look. Not super high priority :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CPU Bound Issue in Parser with Complex Grammar (Possible Error with handling of Zero-Width/empty Strings)
2 participants