Use HasSuffix to check for suffix

[amangale]

For checking the existence of a workspace, the existing regular expression match is not required and is prone to failure. Given that the workspace name is essentially a suffix, the idiomatic way would be to use HasSuffix.

[james03160927]

Hi @amangale, I believe this change might not be backward compatible since it alters the existing behavior. Could you elaborate on why this change is necessary and clarify what you mean by "prone to failure"?

[amangale]

Hi @amangale, I believe this change might not be backward compatible since it alters the existing behavior. Could you elaborate on why this change is necessary and clarify what you mean by "prone to failure"?

Hi @james03160927 -
The earlier code was looking for the ws name at the end of the string which is a suffix.
We recently upgraded to TF v1.10 and Terragrunt v0.72 and modified the logging. This broke WorkspaceSelectOrNewE since the output of terraform workspace list was a different string with the ws name at the end.
I have this sample code: https://go.dev/play/p/g8JiafkjXmU
It demonstrates backward compatibility. If there is a specific use case you can share, I can modify the PR to accommodate it.

[james03160927]

If we can modify the code to support the same functionality while also accommodating new use cases with the upgrade, it will ensure that existing users do not encounter sudden errors, especially in scenarios where their automatic setups update to the latest Terratest version.