Add marshal for request is a x-www-form-urlencoded and response is a json

[jinleileiking]

#528
#7

After 2 days reading the source code. I found a better way for this problem.

The full curl is :

➜  ~ git:(master) ✗ curl '10.64.7.106:8933/form'  -d 'str=333&int=444' -XPOST -H 'Content-Type: application/x-www-form-urlencoded'
{"errno":444,"errmsg":"333"}

[jinleileiking]

Can this be merged?

[jinleileiking]

@yugui @tmc

[jinleileiking]

@achew22

[achew22]

@jinleileiking, thanks so much for your efforts so far! This seems like an interesting marshaller to add, there are just a few things that need to be done before it can be considered for inclusion in the mainline repo.

• Unit Tests of the file in question
• Documentation of how one would use this new functionality
• Coverage in end to end tests (to ensure I don't accidentally make your code regress when doing a refactoring later)

In the meantime, since the marshaller is a pluggable part of the system I would encourage you to bring this code into the mainline of your project to get you un-stuck.

[jinleileiking]

@achew22 Thank you. I will add these doc, ut,cov things.

Suggestion:

Shall we add a marshal-contrib project to make these non-official marshaler easy to plug?

[johanbrandhorst]

Looks like we're still missing tests and documentation here.

[johanbrandhorst]

Please rebase on master for new CI functionality.

[johanbrandhorst]

Stale