fix(deps): Relax the minimum required go version #5022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the `go` directive to a patch version above `.0` causes issues for downstream code bases that have their `go` directive set to the `.0` patch version of Go.
|
A similar issue has been discussed in grpc/grpc-go#7624 (comment) |
johanbrandhorst
approved these changes
Dec 5, 2024
| go 1.22.7 | ||
|
|
||
| toolchain go1.23.4 | ||
| go 1.22.0 |
There was a problem hiding this comment.
Thanks for this, we only updated the version because gRPC updated their version. I expect we won't be able to merge this until there's a new tagged gRPC version with the relaxed Go constraint.
There was a problem hiding this comment.
gRPC release a new version relaxing the version requirement https://github.com/grpc/grpc-go/releases/tag/v1.68.1. This was merged in #5018.
|
Thanks for your contribution! |
|
You are welcome, solved an internal issue for us. |
bobrik
added a commit
to bobrik/grpc-gateway
that referenced
this pull request
Dec 25, 2024
This is a continuation of grpc-ecosystem#5022 It is mirroring grpc-go: grpc/grpc-go#7831
|
Continued: #5094 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the
godirective to a patch version above.0causes issues for downstream code bases that have theirgodirective set to the.0patch version of Go.References to other Issues or PRs
Have you read the Contributing Guidelines?
Brief description of what is fixed or changed
Other comments