Extend google.protobuf.EnumOptions for Schema #4931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hown3d
commented
Nov 10, 2024
johanbrandhorst
approved these changes
Nov 21, 2024
auto-merge was automatically disabled
November 25, 2024 11:41
Head branch was pushed to by a user without write access
Signed-off-by: Lukas Hoehl <[email protected]>
Signed-off-by: Lukas Hoehl <[email protected]>
auto-merge was automatically disabled
November 27, 2024 08:32
Head branch was pushed to by a user without write access
|
🎉 thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs
Fixes #2671
Brief description of what is fixed or changed
Allows to set options on proto enums with a new message
EnumSchema.EnumSchemais a subset of theSchemamessage that contains only fields that are applicable on enums.Other comments
PR is based mostly on #2855 with a few adjustments