Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support field extensions with use_allof_for_refs #3100

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

same-id
Copy link
Contributor

@same-id same-id commented Dec 27, 2022

References to other Issues or PRs

Have you read the Contributing Guidelines?

Yes

Brief description of what is fixed or changed

Allow extensions to be used with the recently added AllOf feature

Other comments

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for this, I think it's probably a good time to add an example protobuf file that is generated with this option turned on, so we can see the difference introduced by this sort of chance. Please add a small new file to the https://github.com/grpc-ecosystem/grpc-gateway/tree/main/examples/internal/proto/examplepb folder. You'll need a new buf.gen.yaml file which sets this option, see the existing files in the directory for an example. Thanks!

@same-id
Copy link
Contributor Author

same-id commented Dec 28, 2022

Will do.

@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 18, 2023
@same-id
Copy link
Contributor Author

same-id commented Jun 18, 2023

Hey, still haven't got to creating a whole new example protobuf.

I see that some other PRs extending my work have also made their way there:

#3240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants