Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes no longer needed code to support internet explorer browser for the dropdown menus.
This PR potentially fixes Issue #6879
Where should the reviewer start?
src\js\components\Drop\StyledDrop.js
What testing has been done on this PR?
I was able to test the impact in chrome and firefox, I dont have a mac so I was unable to test it on Safari.
How should this be manually tested?
Adding extra text to the dropdown elements to check for text overflow.
Do Jest tests follow these best practices?
screen
is used for querying.userEvent
is used in place offireEvent
.asFragment()
is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
Screenshots (if appropriate)
Chrome code disabled:
Edge code disabled:
Edge code enabled:
Firefox code disabled:
Do the grommet docs need to be updated?
No.
Should this PR be mentioned in the release notes?
No.
Is this change backwards compatible or is it a breaking change?
Backwards compatible.