Added a "justify" to the ExpanderControl component to make the icon v… #6570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixing two visual bugs.
justify="center"
to the ExpanderControl component to make the icon vertically centered and to handle non-standard themes or styling.use-keyboard.js
which caused this effect. Removed the "usingKeyboard", the only case I could find where this would be applicable would be using theonSelect
use-case, but that still works as intended after manual testing. I would appreciate some input whether which is correct though.Where should the reviewer start?
src/components/DataTable/ExpanderCell.js
andsrc/components/DataTable/Body.js
are the only files changed except the updated snapshot.What testing has been done on this PR?
usingKeyboard
, I might need help here to verify it's not affecting something I'm not aware of, I'm not too familiar with grommet.How should this be manually tested?
The storybooks should suffice.
Do Jest tests follow these best practices?
screen
is used for querying.userEvent
is used in place offireEvent
.asFragment()
is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
This partially resolves #6344
Screenshots (if appropriate)
Do the grommet docs need to be updated?
No
Should this PR be mentioned in the release notes?
No
Is this change backwards compatible or is it a breaking change?
Backwards compatible