Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 10 #206

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Laravel 10 #206

wants to merge 10 commits into from

Conversation

limenet
Copy link

@limenet limenet commented Mar 12, 2023

Core changes:

  • Adds support for Laravel 10
  • Use PHPUnit 10
  • Use namespaces in tests

Packages changes thanks to https://github.com/spatie/package-skeleton-laravel:

  • Use GitHub Actions instead of Travis CI
  • Use PHPStan to ensure code quality
  • Use Laravel Pint to fix code style

Some changes may not be required, let me know if/what you'd like me to revert. And thanks for all your work!

limenet and others added 10 commits March 12, 2023 11:41
change creds

doctrine/dbal

mysql creds

bump

mysql

mysql ext

change mysql

sleep

run against PRs

sleep

mysql

call parent

use mysql 8

use delta comparison

use delta

disable fail-fast

cleanup

dbal conflict

fail fast
phpstan

Fix styling

Fix styling

Fix styling
Fix styling

Fix styling

Fix styling

fixup! phpstan
Fix styling
Fix styling

cleanup

fix tests

Fix styling

fix test

fix test

Fix styling

fix tests

debugging tests
@asanikovich
Copy link

@OzanKurt
Copy link

OzanKurt commented Jul 6, 2023

@limenet Can you please publish this pull request as a new package?

This package is not being maintained since 2020.

@limenet
Copy link
Author

limenet commented Jul 7, 2023

@OzanKurt Normally I'm hesitant to take over a package but as you mentioned, this package appears to be abandoned, so there's a new repository now over at https://github.com/limenet/laravel-mysql-spatial.

Before I tag a release, could you please give it a try?

  1. See https://github.com/limenet/laravel-mysql-spatial#migration-from-grimzylaravel-mysql-spatial for a (very) short migration guide
  2. Please install the package using composer require limenet/laravel-mysql-spatial:dev-master for now

If you find any issues, please let me know by opening an issue (or even a pull request!). Thank you!

Compared to this PR, I made a few more changes that shouldn't affect functionality (except for the namespace change mentioned in the README):

  • Changed namespace from Grimzy\ to Limenet\
  • PHPStan level increased from 6 to 8
  • Suppressed a deprecation notice
  • Used rector to upgrade code

@OzanKurt
Copy link

OzanKurt commented Jul 7, 2023

@limenet I've alsi copied to a custom package for personal use, I've been using some of the functionality that the package offers. I've not had any problems so far.

Your readme looks amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants