Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flip y,x #108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

flip y,x #108

wants to merge 2 commits into from

Conversation

vahidalvandi
Copy link

change store in db lng,lat

@nazaninhesari
flip y,x
0105b98 
change store in db lng,lat
@vahidalvandi
Copy link
Author

please merge with master

@vahidalvandi vahidalvandi mentioned this pull request Sep 28, 2019
Open
@grimzy
Copy link
Owner

grimzy commented Sep 30, 2019

This PR doesn't pass the tests and code style checks.

If we were to switch the order, then we need to find a way to let the existing package users to use either Point($lat, $lng) or switch to Point($lng, $lat).

@vahidalvandi
Copy link
Author

how i can fix this test ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vahidalvandi @grimzy @nazaninhesari