Fix process_field so that it works for m2m fields in Django 2.0
#107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for direct assignment in manytomany fields was removed in Django 2.0 (see: https://docs.djangoproject.com/en/2.0/releases/2.0/#features-removed-in-2-0). This commit adds an extra param to `process_field` to indicate that the field being processed is a m2m and assignment should be handled through `.set` instead.
|
While waiting for this to be merged, I found this library a pretty easy drop-in replacement: https://model-mommy.readthedocs.io/en/latest/index.html. |
|
Perhaps the tox matrix needs to updated to include Django 1.10, 1.11, and 2.0. This PR is not likely to be merged while tests are failing, even if it is because the travis environment is not supporting those versions of python. |
|
i prefer PR #110 fix the gis module too |
This was referenced Nov 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for direct assignment in manytomany fields was removed in Django 2.0 (see: https://docs.djangoproject.com/en/2.0/releases/2.0/#features-removed-in-2-0).
This commit adds an extra param to
process_fieldto indicate that the field being processed is a m2m and assignment should be handled through.setinstead.