[BUGFIX] Pass the temp_table_schema_name to SQLAlchemyBatchData class #10572
Conversation
Pass batch_spec_passthrough to the SQLAlchemyBatchData so that the user can configure a temp_table_schema_name for Snowflake.
👷 Deploy request for niobium-lead-7998 pending review.Visit the deploys page to approve it
|
|
A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GX in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution: Individual Contributor License Agreement v1.0 Once you have signed the CLA, you can add a comment with the text Please reach out to the #gx-community-support channel, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error. Users missing a CLA: mathiasflorin |
| @@ -1266,6 +1266,7 @@ def get_batch_data_and_markers( | |||
| execution_engine=self, | |||
| selectable=selectable, | |||
| create_temp_table=create_temp_table, | |||
| temp_table_schema_name=temp_table_schema_name, | |||
There was a problem hiding this comment.
The sqlalchemy_batch_data.py code uses temp_table_schema_name variable in self._generate_selectable_from_selectable.
This method then calls _generate_selectable_from_selectable, passing temp_table_schema_name.
I am using Snowflake as the database engine. With this change, the _create_temporary_tablemethod allows me to create the temporary table in another schema.
I am using temp_table_schema_name with batch_spec_passthrough for the validations' batch request.
|
@cla-bot check |
Pass
temp_table_schema_nameto theSQLAlchemyBatchDataclass to configure the temporary table in Snowflake.I didn't run the tests because compiling pandas failed on my MacBook Pro, and I didn't want to spend more time on it.
invoke lint(usesruff format+ruff check)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!