Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Update setup.py #10497

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bramiozo
Copy link

@bramiozo bramiozo commented Oct 9, 2024

Seems to be a minor discrepancy with the pypi and git badge. I am assuming that 3.12 is a typo here, given the "<".

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Seems to be a minor discrepancy with the pypi and git badge. I am assuming that 3.12 is a typo here, given the "<".
Copy link

netlify bot commented Oct 9, 2024

👷 Deploy request for niobium-lead-7998 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 905c7d7

@gx-cla-bot
Copy link

gx-cla-bot bot commented Oct 9, 2024

A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GX in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution:

Individual Contributor License Agreement v1.0
Software Grant and Corporate Contributor License Agreement v1.0

Once you have signed the CLA, you can add a comment with the text @cla-bot check and the bot will update the PR status!

Please reach out to the #gx-community-support channel, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error.

Users missing a CLA: bramiozo

@bramiozo bramiozo changed the title Update setup.py [MAINTENANCE] Update setup.py Oct 9, 2024
@bramiozo
Copy link
Author

bramiozo commented Oct 9, 2024

There seems to be a bit of "git overhead"here, the change is simply for the Python version requirement. Please glance at it for 1 second and merge if appropriate, thanks.

Copy link
Contributor

@tyler-hoffman tyler-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants