fix: Stop a tag with href of 'javascript:void 0' from navigating (#3567)

* fix: prevent default behavior of clicking a tag href. Closes #3565 * added changeset
graphql · Mar 26, 2024 · fc7de5a · fc7de5a
1 parent 7e86dc4
commit fc7de5a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/.changeset/sharp-rules-hide.md b/.changeset/sharp-rules-hide.md
@@ -0,0 +1,5 @@
+---
+'codemirror-graphql': patch
+---
+
+tooltip a tag's click listener calls event.preventDefault() to stop navigating away from page
diff --git a/packages/codemirror-graphql/src/info.ts b/packages/codemirror-graphql/src/info.ts
@@ -299,6 +299,9 @@ function text(
  // want clicking the node to navigate anywhere.
  node.href = 'javascript:void 0'; // eslint-disable-line no-script-url
  node.addEventListener('click', (e: MouseEvent) => {
+ // Although an href of 'javascript:void 0' should never navigate away from the page,
+ // that is not always the case: https://github.com/graphql/graphiql/issues/3565
+ e.preventDefault();
  onClick(ref, e);
  });
  } else {