Introduce Lookup Directive. #30
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilkisiela
approved these changes
Apr 11, 2024
dariuszkuc
reviewed
Apr 12, 2024
dariuszkuc
reviewed
Apr 12, 2024
dariuszkuc
reviewed
Apr 12, 2024
dariuszkuc
reviewed
Apr 12, 2024
dariuszkuc
reviewed
Apr 12, 2024
benjie
reviewed
May 23, 2024
| } | ||
|
|
||
| extend type Person { | ||
| id: ID! # matches the argument of personById | ||
| type Person @key(fields "id") @key(fields "name") { |
There was a problem hiding this comment.
Suggested change
| type Person @key(fields "id") @key(fields "name") { | |
| type Person @key(fields: "id") @key(fields: "name") { |
| } | ||
|
|
||
| interface Node { | ||
| interface Node @key(fields "id") { |
There was a problem hiding this comment.
Suggested change
| interface Node @key(fields "id") { | |
| interface Node @key(fields: "id") { |
| } | ||
|
|
||
| union Entity = Cat | Dog | ||
|
|
||
| extend type Dog { | ||
| type Dog @key(fields "id categoryId") { |
There was a problem hiding this comment.
Suggested change
| type Dog @key(fields "id categoryId") { | |
| type Dog @key(fields: "id categoryId") { |
| id: ID! | ||
| categoryId: Int | ||
| } | ||
|
|
||
| extend type Cat { | ||
| type Cat @key(fields "id categoryId") { |
There was a problem hiding this comment.
Suggested change
| type Cat @key(fields "id categoryId") { | |
| type Cat @key(fields: "id categoryId") { |
| field `Query.personById` and the field `Person.id` on the return type of the | ||
| field are semantically the same. This information is used to infer an entity | ||
| resolver for `Person` from the field `Query.personById`. | ||
| type Dog @key(fields "id categoryId") { |
There was a problem hiding this comment.
Suggested change
| type Dog @key(fields "id categoryId") { | |
| type Dog @key(fields: "id categoryId") { |
| ```graphql example | ||
| extend type Query { | ||
| personById(id: ID! @is(field: "id")): Person @entityResolver | ||
| type Cat @key(fields "id") { |
There was a problem hiding this comment.
Suggested change
| type Cat @key(fields "id") { | |
| type Cat @key(fields: "id") { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the
@entityReslolverto@lookupand introduces the agreed characteristics to the specification.TODOs: