feat(juniper_codegen): add conversions for enum variants to strings #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Thank you for the PR and welcome! 🍻 First, I think there are some legit errors on CI related to this PR: (sorry, our CI is a bit messy right now...I am working to clean it up). Second, I think this sounds like a great change but need to think about it a bit more. I haven't really touched enums too much 😄 |
I see those errors but none are related to the code I added, so I don't know how to make sense of them . Can you provide any guidance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR expands the
GraphQLEnumderive macro to provide conversions from enum variants into strings. Currently, the macro only provides conversions forInputValue, but in my usage it became necessary to map enum variants intoValue::scalar::<String>types so that they can be used in GraphQL responses, specifically as the second parameter ofFieldError::new. Mapping enum variants to strings directly, rather than a Juniper type, is an artifact of my not knowing much.I'm new to Rust and even newer to Juniper, so this PR is intended for review and discussion, and I am happy to incorporate any feedback.