Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle mutlipart/form-data #43

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

koblas
Copy link

@koblas koblas commented Aug 1, 2018

This PR should support Multipart form-data file upload requests as specified by https://github.com/jaydenseric/graphql-multipart-request-spec -- which is adopted by the Apollo team. It also works without file uploads as a general handler.

@coveralls
Copy link

coveralls commented Aug 1, 2018

Coverage Status

Coverage increased (+2.6%) to 89.231% when pulling 5f3718a on koblas:master into 59006c0 on graphql-go:master.

@koblas
Copy link
Author

koblas commented Aug 21, 2018

@chris-ramon Nudge - would it be possible to have this looked at?

@duong-se
Copy link

duong-se commented Oct 8, 2018

hi all, When will it merge to master ?

@koblas
Copy link
Author

koblas commented Oct 8, 2018

@chris-ramon Any chance that this could get a review, will clean up the conflict shortly.

@appleboy
Copy link

appleboy commented Dec 9, 2018

@koblas conflicts

@koblas
Copy link
Author

koblas commented Dec 10, 2018

@appleboy Conflicts resolved... Hopefully, someday @chris-ramon will feel like merging.

@danjenson
Copy link

Can we merge this?

@hongbo-miao
Copy link

hongbo-miao commented Aug 28, 2021

While waiting this being merged, found an alternative handler supporting mutlipart/form-data created by @asif-mahmud.

Originally posted at graphql-go/graphql#607
Library is at https://github.com/asif-mahmud/gingraphql

Just provide one more option 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants