Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues with indentation #313

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Fix some issues with indentation #313

merged 1 commit into from
Apr 21, 2023

Conversation

sungam3r
Copy link
Member

@sungam3r sungam3r commented Apr 21, 2023

I filed a more general issue in #314 . Eventually I'll fix it but not now since I have other work to do.

@github-actions github-actions bot added the test Pull request that adds new or changes existing tests label Apr 21, 2023
Comment on lines 866 to 871
node is GraphQLFieldDefinition ||
node is GraphQLEnumValueDefinition ||
node is GraphQLRootOperationTypeDefinition ||
node is GraphQLDirectiveLocations && Options.EachDirectiveLocationOnNewLine ||
node is GraphQLUnionMemberTypes && Options.EachUnionMemberOnNewLine ||
node is GraphQLArgumentsDefinition && node.Comments?.Count > 0
node is GraphQLArgumentsDefinition && HasPrintableComments(node)

Check notice

Code scanning / CodeQL

Complex condition

Complex condition: too many logical operations in this expression.
@codecov-commenter
Copy link

Codecov Report

Merging #313 (c795a24) into master (bb6a168) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
- Coverage   96.23%   96.23%   -0.01%     
==========================================
  Files          85       85              
  Lines        4892     4889       -3     
  Branches      476      476              
==========================================
- Hits         4708     4705       -3     
  Misses        184      184              
Impacted Files Coverage Δ
src/GraphQLParser/Visitors/SDLPrinter.cs 99.73% <100.00%> (-0.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sungam3r sungam3r added the bugfix Pull request that fixes a bug label Apr 21, 2023
@sungam3r sungam3r merged commit 20e9186 into master Apr 21, 2023
@sungam3r sungam3r deleted the indents branch April 21, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug test Pull request that adds new or changes existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants