Fix Flaky Order of Directive Validation #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the use of a map behind the directiveNames, iterating over them is done in random order. When there are multiple directives that are duplicated, the order of errors can change between runs, and be inconsistent with the expecated result. This issue is also the case for other types which use a map to validate names, however the other cases currently have no tests validating this condition. To resolve the immediate issue of flaky tests, addressing just the directives case for now. Resolution of other cases should be accompanied by tests exposing the issue.
pavelnikolov
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the use of a map behind the directiveNames, iterating over them is done in random order. When there are multiple directives that are duplicated, the order of errors can change between runs, and be inconsistent with the expecated result.
This issue is also the case for other types which use a map to validate names, however the other cases currently have no tests validating this condition. To resolve the immediate issue of flaky tests, addressing just the directives case for now. Resolution of other cases should be accompanied by tests exposing the issue.