cleanup and some small enhancements #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l performance lags add up
…ilterProxy. this lets you define the filter as a Spring bean and take advantage of bean builder syntax, autowiring, etc. it also makes the plugin more configurable since other plugins can change how the filters work, instead of just being able to add new processors. also converted to use OncePerRequestFilter to clean up the code
|
Burt - can you resubmit this to the "develop" branch? Otherwise we are going to have trouble merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "whitespace and general cleanup" commit is a large one and has no real functional changes, mostly just whitespace, formatting, etc.
The other two commits are more important though. I rewrote the filter in Java since the small overhead that Groovy incurs adds up, and there's nothing there that needs Groovy. The third commit doesn't change how anything works, just how the filters are registered in web.xml. By using Spring beans you gain a lot more flexibility.
I'm pretty sure that the 2nd and 3rd commits don't depend on the first, so if there is a probem with that one you could cherry pick the two, or revert that one. All of the tests pass though, and I added new ones for the Spring stuff.