Redirect error msg responses without sessionId to all sessions and the connection #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
force-pushed
the
fix/861-redirect-error-msg
branch
from
9cdfb46
to
b34d0a4
Compare
ankur22
force-pushed
the
fix/861-redirect-error-msg
branch
2 times, most recently
from
4b66de9
to
8103b77
Compare
If we receive an error response with an id, but not sessionId, there's a slim chance that this response should be redirected to a session but will instead be redirected to the connection's event loop. This means that there is a chance that we could end up with a handler that is waiting for a response indefinitely (or until a timeout occurs). Since we cannot know exactly which session the response should be redirected to, we're sending it to all live sessions as well as the connection's event loop. Most handlers should ignore the extra error message, and the handler waiting for the msg with the unique msgId will action on it. If no handlers are alive or the session has already been closed that this response msg should go to, then no handlers will action on it either.
This makes it simpler to work with the mutex
ankur22
force-pushed
the
fix/861-redirect-error-msg
branch
from
e9f3232
to
71cf2dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
If we receive an error response with an
id, but nosessionId, there's a slim chance that this response should be redirected to asessionbut it will instead be redirected to theconnection's event loop. This means that there is a chance that we could end up with a handler that is waiting for a response indefinitely (or until a timeout occurs).Since we have no knowledge of the
sessionIdfrom the response msg, we're now sending it to all livesessions as well as theconnection's event loop.Most handlers should ignore the extra error message, whilst the handler waiting for the msg (with the unique
msgId) will action on it. If no handlers are alive or the associatedsessionhas already been closed, then no handlers will action on it still since we're now working with uniquemsgIds at the connection scope level.Checklist