TraceQL performance improvements #4114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdisibio
requested review from
joe-elliott,
annanay25,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
| @@ -144,6 +146,7 @@ func (s *span) AttributeFor(a traceql.Attribute) (traceql.Static, bool) { | |||
| if attrs[0].a.Name == s { | |||
| return &attrs[0].s | |||
| } | |||
| return nil | |||
| @@ -230,27 +239,37 @@ func (s *span) AttributeFor(a traceql.Attribute) (traceql.Static, bool) { | |||
|
|
|||
| // name search in span, resource, link, and event to give precedence to span | |||
| // we don't need to do a name search at the trace level b/c it is intrinsics only | |||
| if attr := findName(a.Name, s.spanAttrs); attr != nil { | |||
| return *attr, true | |||
| if len(s.spanAttrs) > 0 { | |||
There was a problem hiding this comment.
Why don't we move this logic to the findName method instead? We are already counting the length. We can add a first case:
if len(attrs) == 0 {
return nil
}We are adding a new entry in the call stack but the code is nicer
There was a problem hiding this comment.
Right, this way it's skipping the method call entirely, so it ends up faster. I think it's worth it, even though the code is less nice.
| @@ -152,47 +155,53 @@ func (s *span) AttributeFor(a traceql.Attribute) (traceql.Static, bool) { | |||
| if attrs[1].a.Name == s { | |||
| return &attrs[1].s | |||
| } | |||
| return nil | |||
There was a problem hiding this comment.
Not sure if we could return directly the StaticNil from here
|
For completeness ran benchmarks on metrics. Nice improvement to the compare() function, some smaller wins for other queriers, although harder to see because they are noiser: |
knylander-grafana
pushed a commit
to knylander-grafana/tempo-doc-work
that referenced
this pull request
Sep 26, 2024
* performance improvements * Exit binop early withou evaluating RHS if possible
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Some micro-optimizations to improve traceql engine attribute checks. Search bottleneck is usually in the storage layer, but some complex queries, particularly ones with unscoped attributes, are bottlenecked in the engine.
The memory improvement primarily comes from fixing the for loop in span.AttributeFor.
This loop allocs because the address of the loop var must escape:
But this version doesn't because we take the address of the existing slice entry, which was the intention.
The speed improvement is from also short-circuiting binary operations more like a real compiler if statement does. Two cases can exit early and don't need to evaluate both sides:
This is the main speed improvement in
traceOrMatchandtraceOrNoMatchBenchmark
There is a particularly tough query run internally that was the original impetus for this change:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]