Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: TraceQL metrics: max over time #4065

Merged
merged 5 commits into from
Sep 10, 2024
Merged

feat: TraceQL metrics: max over time #4065

merged 5 commits into from
Sep 10, 2024

Conversation

javiermolinar
Copy link
Contributor

What this PR does:
It implements the max_over_time aggregation function

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@javiermolinar javiermolinar added type/docs Improvements or additions to documentation enhancement New feature or request labels Sep 9, 2024
@javiermolinar javiermolinar marked this pull request as ready for review September 9, 2024 13:48
knylander-grafana
knylander-grafana reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding documentation! I have some questions about examples, but otherwise looks good.

@javiermolinar
Copy link
Contributor Author

Thank you for adding documentation! I have some questions about examples, but otherwise looks good.

You were right about the examples. Thank you for reviewing it!

mdisibio
mdisibio approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@mdisibio mdisibio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - We got all the hard changes out of the way with min_over_time, and this is straightforward. 👍

docs/sources/tempo/traceql/metrics-queries.md Outdated Show resolved Hide resolved
@mdisibio mdisibio merged commit 4013355 into grafana:main Sep 10, 2024
17 checks passed
@javiermolinar javiermolinar deleted the max-over-time branch September 10, 2024 15:23
@09jvilla 09jvilla mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knylander-grafana knylander-grafana knylander-grafana left review comments

@mdisibio mdisibio mdisibio approved these changes

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner

@annanay25 annanay25 Awaiting requested review from annanay25

@mapno mapno Awaiting requested review from mapno mapno is a code owner

@yvrhdn yvrhdn Awaiting requested review from yvrhdn yvrhdn is a code owner

@zalegrala zalegrala Awaiting requested review from zalegrala zalegrala is a code owner

@electron0zero electron0zero Awaiting requested review from electron0zero electron0zero is a code owner

@ie-pham ie-pham Awaiting requested review from ie-pham ie-pham is a code owner

@stoewer stoewer Awaiting requested review from stoewer stoewer is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request type/docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javiermolinar @mdisibio @knylander-grafana