Prepare OnCall for Unified Slack App #4232

Konstantinov-Innokentii · 2024-04-16T04:33:27Z

This PR does a bunch of changes to prepare OnCall for Unified Slack App:

Install Slack via Chatops-Proxy. This change contains two parts: getting a Slack install link from chatops-proxy (code) and receiving a "slack installed" event from chatops-proxy (code). Also it means that OnCall doesn't need to register slack_links anymore when slack is connected/disconnected. These changes are behind UNIFIED_SLACK_APP_ENABLED flag and should be no-op if flag is not enabled.
Get rid of Multiregionatily restrictions - instrument all slack interactions with a ProxyMeta - json data telling chatops-proxy where to route the interaction. Note, that it doesn't apply for "Add to resolution notes" message action - it will be handled differently in following PR.
Move all chatops-proxy related stuff from common/oncall-gateway to apps/chatops-proxy

Minor changes:

Remove usage of CHATOPS_V3 flag. Chatops v3 is already released (It's a refactoring from previous quarter)

It's a modal on the alert group message, not mesasge action (in 3-dot menu).

engine/apps/slack/oauth.py

Move slack installation & uninstallation code to separate functions to reuse betwen social-auth and chatops-proxy

matiasb

Thanks for the updates! 👍
LGTM

matiasb · 2024-05-23T17:51:56Z

engine/apps/chatops_proxy/tests/test_events.py

+ "payload": {
+ # It's not actual payload we are getting from slack, just a placeholder
+ "slack_id"
+ "some_slack_id"


Is this sample data ok ^?

Thanks for noticing. missed a coma. Anyway, I went ahead and used a more accurate payload example from slack docs instead of placeholder

Konstantinov-Innokentii · 2024-05-24T08:21:47Z

Thanks for the updates! 👍 LGTM

Thanks! Added more tests covering our slack installation.

…rafana/oncall into handle_chatops_proxy_broadcast

Konstantinov-Innokentii added 5 commits April 9, 2024 21:57

Add chatops-proxy routing data to AlertGroup Buttons

6ee54a4

Make "Responders" button work

3a699c4

Make "Attach to" work

9581552

Make "Resolution notes" btn work

8bd9ef3

It's a modal on the alert group message, not mesasge action (in 3-dot menu).

Start work on the slack installation from the chatops-proxy

2dda654

Konstantinov-Innokentii temporarily deployed to github-pages April 16, 2024 04:33 — with GitHub Actions Inactive

github-advanced-security bot found potential problems Apr 16, 2024

View reviewed changes

engine/apps/slack/oauth.py Fixed Show fixed Hide fixed

Support slack installation via chatops-proxy.

b187082

Move slack installation & uninstallation code to separate functions to reuse betwen social-auth and chatops-proxy

Konstantinov-Innokentii temporarily deployed to github-pages April 24, 2024 08:23 — with GitHub Actions Inactive

Fix get_installation_link_from_chatops_proxy util

c97a994

Konstantinov-Innokentii temporarily deployed to github-pages April 24, 2024 09:33 — with GitHub Actions Inactive

Add SELF_HOSTED_STACK_ID env var

97d140a

Konstantinov-Innokentii temporarily deployed to github-pages April 26, 2024 04:28 — with GitHub Actions Inactive

draft event receiver

7103c5c

Konstantinov-Innokentii had a problem deploying to github-pages April 26, 2024 12:51 — with GitHub Actions Failure

Merge branch 'slack_add_tenant_id' into handle_chatops_proxy_broadcast

0131c47

Konstantinov-Innokentii mentioned this pull request Apr 29, 2024

Instrument slack elements with routing data needed for chatops-proxy #4196

Closed

Konstantinov-Innokentii had a problem deploying to github-pages April 29, 2024 06:55 — with GitHub Actions Failure

Reorganize chatops-event handler

4cf952c

Konstantinov-Innokentii had a problem deploying to github-pages April 29, 2024 08:14 — with GitHub Actions Failure

Fix types

5cf0bb7

Konstantinov-Innokentii had a problem deploying to github-pages April 29, 2024 08:35 — with GitHub Actions Failure

Fixes

0215e8c

Konstantinov-Innokentii had a problem deploying to github-pages April 29, 2024 09:57 — with GitHub Actions Failure

Move common.oncall_gateway to apps.chatops-proxy

70f0e53

Konstantinov-Innokentii had a problem deploying to github-pages April 30, 2024 07:02 — with GitHub Actions Failure

Introduce UNIFIED_SLACK_APP_ENABLED env var

62204f2

Konstantinov-Innokentii had a problem deploying to github-pages April 30, 2024 07:37 — with GitHub Actions Failure

Fix registering oncall tenant

ed0f6de

Konstantinov-Innokentii had a problem deploying to github-pages April 30, 2024 09:26 — with GitHub Actions Failure

Add tests for uninstall_slack_integration

a5eb5fd

matiasb approved these changes May 23, 2024

View reviewed changes

Konstantinov-Innokentii and others added 3 commits May 24, 2024 14:19

Simplify test_root_event_handler

3afcb4f

Correct test data

705e117

Merge branch 'dev' into handle_chatops_proxy_broadcast

bede2ad

teodosii temporarily deployed to github-pages May 24, 2024 07:55 — with GitHub Actions Inactive

Add tests for start slack installation via social auth

89a3c0c

Konstantinov-Innokentii had a problem deploying to github-pages May 24, 2024 08:21 — with GitHub Actions Error

teodosii added 2 commits May 24, 2024 11:27

lint

f3a951d

Merge branch 'handle_chatops_proxy_broadcast' of https://github.com/g…

e3dd665

…rafana/oncall into handle_chatops_proxy_broadcast

teodosii temporarily deployed to github-pages May 24, 2024 08:28 — with GitHub Actions Inactive

Merge branch 'dev' into handle_chatops_proxy_broadcast

82f3695

Konstantinov-Innokentii temporarily deployed to github-pages May 24, 2024 10:51 — with GitHub Actions Inactive

Merge branch 'dev' into handle_chatops_proxy_broadcast

6e6e120

Konstantinov-Innokentii temporarily deployed to github-pages May 27, 2024 04:01 — with GitHub Actions Inactive

Merge branch 'dev' into handle_chatops_proxy_broadcast

8811757

Konstantinov-Innokentii temporarily deployed to github-pages May 29, 2024 08:00 — with GitHub Actions Inactive

vadimkerr approved these changes May 29, 2024

View reviewed changes

Verify chatops-proxy events signature

8d438a3

Konstantinov-Innokentii temporarily deployed to github-pages June 3, 2024 06:34 — with GitHub Actions Inactive

Merge branch 'dev' into handle_chatops_proxy_broadcast

aae84ab

Konstantinov-Innokentii temporarily deployed to github-pages June 3, 2024 07:52 — with GitHub Actions Inactive

brojd approved these changes Jun 3, 2024

View reviewed changes

Konstantinov-Innokentii added this pull request to the merge queue Jun 3, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 3, 2024

Konstantinov-Innokentii added this pull request to the merge queue Jun 3, 2024

Merged via the queue into dev with commit 17f448c Jun 3, 2024
21 checks passed

Konstantinov-Innokentii deleted the handle_chatops_proxy_broadcast branch June 3, 2024 09:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare OnCall for Unified Slack App #4232

Prepare OnCall for Unified Slack App #4232

Konstantinov-Innokentii commented Apr 16, 2024 •

edited

matiasb left a comment

matiasb May 23, 2024

Konstantinov-Innokentii May 24, 2024

Konstantinov-Innokentii commented May 24, 2024

Prepare OnCall for Unified Slack App #4232

Prepare OnCall for Unified Slack App #4232

Conversation

Konstantinov-Innokentii commented Apr 16, 2024 • edited

matiasb left a comment

Choose a reason for hiding this comment

matiasb May 23, 2024

Choose a reason for hiding this comment

Konstantinov-Innokentii May 24, 2024

Choose a reason for hiding this comment

Konstantinov-Innokentii commented May 24, 2024

Konstantinov-Innokentii commented Apr 16, 2024 •

edited