[weekly-r316] Cherry-pick: MemPostings.Commit() from prometheus#15374 #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry pick of: https://github.com/prometheus/prometheus/pull/15374/files On top of weekly-r316 Signed-off-by: Oleg Zaytsev <[email protected]>
jesusvazquez
approved these changes
Nov 14, 2024
The current approach is underperforming because all appenders try to Commit(), regardless they actually created series or not. And even if they created series, and those series were already committed, it will still try to grab both locks just to realize there's nothing to commit. We'll solve that by keeping a watermark of what's already committed, and keeping track of the series id's created by that appender. We'll only do the commit operation if there's something to commit. Signed-off-by: Oleg Zaytsev <[email protected]>
There's a lot of things to be done in HeadAppender.Commit(). There's no required particular order for many of them. Sometimes multiple appenders will arrive on the same MemPostings.Commit() call, both having created series in the past. Both of them will wait, one of them will just waste that time, because the first one will most likely commit all the postings needed to be committed by the second one. So this adds a MemPostings.TryCommit(), that will do best effort to try to commit now, and if it's not possible right now (either because someone is Committing, or someone is Adding), it will retry committing later, doing other pending work in the meantime (committing samples, etc.) Signed-off-by: Oleg Zaytsev <[email protected]>
Signed-off-by: Oleg Zaytsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of: prometheus/prometheus#15374
On top of weekly-r316