-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHANGE] regexp . to match \n and optimize performance #702
base: main
Are you sure you want to change the base?
Conversation
|
Shortcut for `.*` matches newlines as well. Add preamble change ^(?s: Add test dotAll flag por al regex Add and fix regex tests Signed-off-by: Mario Fernandez <[email protected]>
Signed-off-by: Owen Williams <[email protected]>
af0e2db
to
39e6e83
Compare
I have signed the agreement although the assistant seems to think I have not |
Also I can either squash the commits down or leave them separate... not sure how important it is to keep the commits in mimir-prometheus relatively close to upstream. |
If they are separate in Prometheus |
Hold on before merging. Not sure we're ready to merge this in |
converted to draft so nobody gets tempted to push the button |
(I'll start the discussion on monday, no need to do so on a friday afternoon) |
This is backported from Prometheus 3.0 prometheus/prometheus#14505
Shortcut for
.*
matches newlines as well.Add preamble change ^(?s:
Add test
dotAll flag por al regex
Add and fix regex tests
Co-authored-by: Mario Fernandez [email protected]