Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zaaphod custom #64

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Zaaphod custom #64

wants to merge 11 commits into from

Conversation

Zaaphod
Copy link
Contributor

@Zaaphod Zaaphod commented Aug 30, 2017

The following issues with AggPas are addressed here:

Freetype.dll needs to be appropriately 32bit or 64bit
Rename Freetype.dll to Freetype32.dll and include FreeType64.dll Please note that Freetype64.dll is just
something I found, so I'm not sure if it is based on the current version or not.

Add a compiler directive to use RBG565 format for use with PTCgraph to make changes in agg_2D.pas

Patch to correct color reversal of red and blue channels when using RGB565 format
* This has now been fixed so agg_color.pas is no longer included in this pull request

There may be a better way to implement these issues, but I figured I would submit a pull request to show how I was able to work around the issues until a permanent solution is available

@Zaaphod
Copy link
Contributor Author

Zaaphod commented Aug 30, 2017

I'm wondering if the change in agg_color.pas should always be made without the compiler directive so that the code on line 134 would read

constructor rgba8.Construct;
begin
b:=int8u(b_ );
g:=int8u(g_ );
r:=int8u(r_ );
a:=int8u(a_ );
end;

The sample program that writes to a file as well as my programs that use PTCGraph require it to be like this, and it doesn't make sense to set blue = red and red = blue... wherever that needed to happen should be changed, but here blue should always be blue and red should always be red.

@Zaaphod
Copy link
Contributor Author

Zaaphod commented Aug 31, 2017

Thanks for fixing agg_color.pas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant