Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve resolution messages in the gradle/gradle build #29007

Merged
merged 1 commit into from
May 8, 2024
Merged

Improve resolution messages in the gradle/gradle build #29007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion build-logic-commons/module-identity/src/main/kotlin/gradlebuild.module-jar.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ fun computeExternalDependenciesNotAccessibleFromProjectDependencies(
while (queue.isNotEmpty()) {
val dependency = when (val result = queue.removeFirst()) {
is ResolvedDependencyResult -> result
else -> throw IllegalArgumentException("Expected ResolvedDependencyResult")
is UnresolvedDependencyResult -> throw result.failure
else -> throw AssertionError("Unknown dependency type: $result")
}

if (dependency.isConstraint) {
Expand Down