Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Tooling API model for obtaining errors of resolved DOM #28902

Closed
wants to merge 42 commits into from

Conversation

jbartok
Copy link
Member

@jbartok jbartok commented Apr 22, 2024

Context

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@jbartok jbartok changed the base branch from master to jb/declarative-dsl/tooling-api-schemas April 22, 2024 08:12
@jbartok jbartok self-assigned this Apr 24, 2024
@jbartok jbartok force-pushed the jb/declarative-dsl/tooling-api-schemas branch 2 times, most recently from f6b9e5b to 1ffbdd4 Compare May 14, 2024 10:29
Base automatically changed from jb/declarative-dsl/tooling-api-schemas to master May 14, 2024 18:50
@jbartok
Copy link
Member Author

jbartok commented May 21, 2024

This has been addressed in a different manner.

@jbartok jbartok closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant