Implement lazy variant API and add androidTest base variant
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunsampathkumar-grabtaxi
changed the title
androidTest base variantvariant API and add androidTest base variant
minkuanlim-grabtaxi
approved these changes
Jul 19, 2023
...lugin/src/main/kotlin/com/grab/grazel/gradle/dependencies/MavenInstallArtifactsCalculator.kt
Show resolved
Hide resolved
Signed-off-by: arunkumar9t2 <[email protected]>
minkuanlim-grabtaxi
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Continuing from #44, this PR add lazy API to
VariantBuildervia newonVariantsAPI. This is essential for making all tasks cacheable and avoiding lot of configuration work during execution. #59This PR also adds new
androidTestbase variant for grouping all dependencies that is declared withandroidTestImplementation, later will be used by #89. This new variant will extend from bothdefaultandtestvariants.Deprecating
MavenInstallCalculatorwhich will be replaced by task based computation in #89