Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource sets not handling manifests correctly #142

Closed

Conversation

arunkumar9t2
Copy link
Contributor

Proposed Changes

Previously resource set was not handling cases where res/assets folders were empty and only manifest existed for a variant. In that case the manifest was completely skipped in the generated code, this fixes it by changing the logic to handle the empty assets/res directories.

Example

    resource_sets = {
        "debug": {
            "manifest": "src/debug/AndroidManifest.xml",
        },
        "main": {
            "manifest": "src/main/AndroidManifest.xml",
        },
    },

Testing

Updated tests

@arunkumar9t2 arunkumar9t2 force-pushed the arun/fix-resource-sets branch 4 times, most recently from b4f83ae to 226057d Compare November 20, 2024 09:11
@arunkumar9t2 arunkumar9t2 force-pushed the arun/fix-resource-sets branch from 226057d to 14eb626 Compare November 20, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants