-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrate bazel_rules_detekt #138
Open
mohammadkahelghi-grabtaxi
wants to merge
1
commit into
master
Choose a base branch
from
integrate-bazel-rules-detekt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammadkahelghi-grabtaxi
requested review from
minkuanlim-grabtaxi,
vanminh-grabtaxi,
arunsampathkumar-grabtaxi,
stevenchao-grabtaxi,
arnav-grabtaxi and
adarsh-grabtaxi
as code owners
June 20, 2024 06:34
mohammadkahelghi-grabtaxi
force-pushed
the
integrate-bazel-rules-detekt
branch
from
June 20, 2024 06:58
77f8ef1
to
f176d38
Compare
arunkumar9t2
suggested changes
Jun 20, 2024
grazel-gradle-plugin/src/main/kotlin/com/grab/grazel/migrate/android/DetektExtractor.kt
Outdated
Show resolved
Hide resolved
grazel-gradle-plugin/src/main/kotlin/com/grab/grazel/migrate/android/DetektExtractor.kt
Outdated
Show resolved
Hide resolved
grazel-gradle-plugin/src/main/kotlin/com/grab/grazel/migrate/android/LintConfigData.kt
Show resolved
Hide resolved
grazel-gradle-plugin/src/main/kotlin/com/grab/grazel/bazel/starlark/Object.kt
Outdated
Show resolved
Hide resolved
grazel-gradle-plugin/src/main/kotlin/com/grab/grazel/gradle/variant/VariantBuilder.kt
Show resolved
Hide resolved
mohammadkahelghi-grabtaxi
force-pushed
the
integrate-bazel-rules-detekt
branch
3 times, most recently
from
June 20, 2024 07:36
c430658
to
3bc18ac
Compare
mohammadkahelghi-grabtaxi
force-pushed
the
integrate-bazel-rules-detekt
branch
from
June 20, 2024 07:44
3bc18ac
to
95fda93
Compare
arunkumar9t2
suggested changes
Jun 20, 2024
@@ -153,7 +153,7 @@ class DefaultVariantBuilderTest { | |||
@Test | |||
fun `assert jvm variants are built`() { | |||
val variants = variantBuilder.build(jvmProject) | |||
assertEquals(2, variants.size) | |||
assertEquals(3, variants.size) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I meant to add a new test case to that actually runs the detekt
logic by setting it up in VariantTestProject.kt
etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integrate bazel_rules_detekt