Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate bazel_rules_detekt #138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohammadkahelghi-grabtaxi
Copy link
Collaborator

integrate bazel_rules_detekt

load("@grab_bazel_common//rules:defs.bzl", "detekt_options", ...)
kotlin_library(
   ...,
    detekt_options = detekt_options(
        baseline = "detekt-baseline.xml",
        all_rules = True,
        auto_correct = True,
        build_upon_default_config = True,
        cfgs = ["//:detekt-config.yml"],
        detekt_checks = ["@detekt_maven//:ru_kode_detekt_rules_compose"],
        disable_default_rule_sets = True,
        enabled = True,
        parallel = True,
    ),
  
)

WORKSPACE Outdated Show resolved Hide resolved
@mohammadkahelghi-grabtaxi mohammadkahelghi-grabtaxi force-pushed the integrate-bazel-rules-detekt branch 3 times, most recently from c430658 to 3bc18ac Compare June 20, 2024 07:36
@mohammadkahelghi-grabtaxi mohammadkahelghi-grabtaxi force-pushed the integrate-bazel-rules-detekt branch from 3bc18ac to 95fda93 Compare June 20, 2024 07:44
@@ -153,7 +153,7 @@ class DefaultVariantBuilderTest {
@Test
fun `assert jvm variants are built`() {
val variants = variantBuilder.build(jvmProject)
assertEquals(2, variants.size)
assertEquals(3, variants.size)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I meant to add a new test case to that actually runs the detekt logic by setting it up in VariantTestProject.kt etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants