-
Notifications
You must be signed in to change notification settings - Fork 20
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'documentation-fixes' into 'master'
Update documentation See merge request mobile/grazel!96
- Loading branch information
Showing
5 changed files
with
61 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
## Proposed Changes | ||
|
||
## Testing | ||
<!--- Please describe how you tested your changes. --> | ||
|
||
## Issues Fixed |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,24 @@ | ||
# Kotlin Databinding Support | ||
|
||
TBA | ||
Databinding support, especially with Kotlin is an ongoing effort. See [issue](https://github.com/bazelbuild/bazel/issues/2694) for details. | ||
|
||
In order to compile Kotlin based Gradle module that uses databinding without much refactors, Grazel uses custom `kt_db_android_library` rules from [grab-bazel-common](https://github.com/grab/grab-bazel-common). See [databinding.bzl](https://github.com/grab/grab-bazel-common/blob/5076af89a1c0fd56f11a09b42eee5e6aa017dd73/tools/databinding/databinding.bzl#L159) for more details. | ||
|
||
Additionally, Grazel employs few [custom patches](https://github.com/grab/grab-bazel-common/tree/master/patches) to Bazel's Android Tools jar for performance and build fixes. | ||
|
||
By default, the patched tools are imported to current build via `android_tools` macro in `WORKSPACE`. | ||
|
||
```python | ||
load("@grab_bazel_common//:workspace_defs.bzl", "android_tools") | ||
|
||
android_tools( | ||
commit = "f74ef90479383a38cef1af33d28a3253031e00c1", | ||
remote = "https://github.com/grab/grab-bazel-common.git", | ||
) | ||
``` | ||
|
||
Commenting out `android_tools` will use the Android tools version shipped with Bazel. | ||
|
||
Supported features: | ||
|
||
* TBA |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters