Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compose support to android_instrumentation_binary #158

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Add compose support to android_instrumentation_binary #158

merged 1 commit into from
Mar 29, 2024

Conversation

minkuan88
Copy link
Contributor

#102 Added compose support for android_library and android_binary but have seem to missed out adding support for android_instrumentation_binary.

This PR will allow the compose compiler to be added to Kotlin compilation in android_instrumentation_binary when enable_compose is set to True.

@minkuanlim-grabtaxi minkuanlim-grabtaxi merged commit 7ce14f2 into grab:master Mar 29, 2024
3 checks passed
@minkuanlim-grabtaxi minkuanlim-grabtaxi deleted the instrumentation-compose-support branch March 29, 2024 07:46
@minkuan88 minkuan88 mentioned this pull request Mar 29, 2024
Merged
minkuanlim-grabtaxi pushed a commit that referenced this pull request Apr 2, 2024
@minkuan88
Add compose support to android_instrumentation_binary (#158)
8da7468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunkumar9t2 arunkumar9t2 arunkumar9t2 approved these changes

@minkuanlim-grabtaxi minkuanlim-grabtaxi Awaiting requested review from minkuanlim-grabtaxi minkuanlim-grabtaxi is a code owner

@vanminh-grabtaxi vanminh-grabtaxi Awaiting requested review from vanminh-grabtaxi vanminh-grabtaxi is a code owner

@arunsampathkumar-grabtaxi arunsampathkumar-grabtaxi Awaiting requested review from arunsampathkumar-grabtaxi arunsampathkumar-grabtaxi is a code owner

@mohammadkahelghi-grabtaxi mohammadkahelghi-grabtaxi Awaiting requested review from mohammadkahelghi-grabtaxi mohammadkahelghi-grabtaxi is a code owner

@stevenchao-grabtaxi stevenchao-grabtaxi Awaiting requested review from stevenchao-grabtaxi stevenchao-grabtaxi is a code owner

@arnav-grabtaxi arnav-grabtaxi Awaiting requested review from arnav-grabtaxi arnav-grabtaxi is a code owner

@adarsh-grabtaxi adarsh-grabtaxi Awaiting requested review from adarsh-grabtaxi adarsh-grabtaxi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minkuan88 @arunkumar9t2 @minkuanlim-grabtaxi