Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic android lint implementation #119

Closed
wants to merge 2 commits into from
Closed

Basic android lint implementation #119

wants to merge 2 commits into from

Conversation

arunkumar9t2
Copy link
Contributor

@arunkumar9t2 arunkumar9t2 commented Oct 20, 2023 •
edited
Loading

Basic android lint implementation via a custom rule.

  • Add dependency on com.android.tools.lint:lint:31.0.2
  • Implement a worker capable of multiplexing that invokes the Lint's CLI commands
  • Implement lint.bzl that generates project.xml for Lint CLI.
  • Connect to existing android_library macro.

Related #120 and pending work

@arunkumar9t2 arunkumar9t2 mentioned this pull request Oct 20, 2023
Closed
7 tasks
@arunkumar9t2 arunkumar9t2 marked this pull request as ready for review October 20, 2023 06:44
@arunsampathkumar-grabtaxi arunsampathkumar-grabtaxi added the enhancement New feature or request label Oct 20, 2023
This was referenced Oct 24, 2023
Closed
Closed
Closed
@arunkumar9t2 arunkumar9t2 deleted the arun/lint branch October 29, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenchao-grabtaxi stevenchao-grabtaxi stevenchao-grabtaxi approved these changes

@roscrazy roscrazy roscrazy approved these changes

@minkuanlim-grabtaxi minkuanlim-grabtaxi Awaiting requested review from minkuanlim-grabtaxi minkuanlim-grabtaxi is a code owner

@vanminh-grabtaxi vanminh-grabtaxi Awaiting requested review from vanminh-grabtaxi vanminh-grabtaxi is a code owner

@arunsampathkumar-grabtaxi arunsampathkumar-grabtaxi Awaiting requested review from arunsampathkumar-grabtaxi arunsampathkumar-grabtaxi is a code owner

@mohammadkahelghi-grabtaxi mohammadkahelghi-grabtaxi Awaiting requested review from mohammadkahelghi-grabtaxi mohammadkahelghi-grabtaxi is a code owner

@arnav-grabtaxi arnav-grabtaxi Awaiting requested review from arnav-grabtaxi arnav-grabtaxi is a code owner

@adarsh-grabtaxi adarsh-grabtaxi Awaiting requested review from adarsh-grabtaxi adarsh-grabtaxi is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arunkumar9t2 @roscrazy @stevenchao-grabtaxi @arunsampathkumar-grabtaxi