-
Notifications
You must be signed in to change notification settings - Fork 15
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix partial lint detectors not running in
android_binary
target (#149)
Fixes #149
- Loading branch information
1 parent
1e751cf
commit e4251d4
Showing
2 changed files
with
74 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,81 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<issues format="5" by="lint 8.0.2" client="" dependencies="true" name="" type="baseline" variant="all" version="8.0.2"> | ||
<issues format="6" by="lint 8.4.0-alpha09" type="baseline" client="" dependencies="true" name="" variant="all" version="8.4.0-alpha09"> | ||
|
||
<issue | ||
id="LongLogTag" | ||
message="The logging tag can be at most 23 characters, was 39 (SomeReallyLongTagForLintToDetectAndWarn)"> | ||
message="The logging tag can be at most 23 characters, was 39 (SomeReallyLongTagForLintToDetectAndWarn)" | ||
errorLine1=" android.util.Log.d("SomeReallyLongTagForLintToDetectAndWarn", "Log message")" | ||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> | ||
<location | ||
file="tests/android/binary/src/main/java/com/grab/test/TestActivity.kt" | ||
line="13"/> | ||
file="../../../../../../../tests/android/binary/src/main/java/com/grab/test/TestActivity.kt" | ||
line="13" | ||
column="29"/> | ||
</issue> | ||
|
||
<issue | ||
id="MissingVersion" | ||
message="Should set `android:versionCode` to specify the application version" | ||
errorLine1="<manifest xmlns:android="http://schemas.android.com/apk/res/android"" | ||
errorLine2=" ~~~~~~~~"> | ||
<location | ||
file="../../../../../../../tests/android/binary/src/main/AndroidManifest.xml" | ||
line="1" | ||
column="2"/> | ||
</issue> | ||
|
||
<issue | ||
id="MissingVersion" | ||
message="Should set `android:versionName` to specify the application version" | ||
errorLine1="<manifest xmlns:android="http://schemas.android.com/apk/res/android"" | ||
errorLine2=" ~~~~~~~~"> | ||
<location | ||
file="../../../../../../../tests/android/binary/src/main/AndroidManifest.xml" | ||
line="1" | ||
column="2"/> | ||
</issue> | ||
|
||
<issue | ||
id="UnusedResources" | ||
message="The resource `R.layout.layout_test` appears to be unused" | ||
errorLine1="<layout xmlns:android="http://schemas.android.com/apk/res/android">" | ||
errorLine2="^"> | ||
<location | ||
file="../../../../../../../tests/android/binary/src/main/res/layout/layout_test.xml" | ||
line="2" | ||
column="1"/> | ||
</issue> | ||
|
||
<issue | ||
id="UnusedResources" | ||
message="The resource `R.layout.layout_test` appears to be unused" | ||
errorLine1="<layout xmlns:android="http://schemas.android.com/apk/res/android">" | ||
errorLine2="^"> | ||
<location | ||
file="../../../../../../../tests/android/library/src/main/res/layout/layout_test.xml" | ||
line="2" | ||
column="1"/> | ||
</issue> | ||
|
||
<issue | ||
id="UnusedResources" | ||
message="The resource `R.string.un_used_resource` appears to be unused" | ||
errorLine1=" <string name="un_used_resource">Unused resource</string>" | ||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> | ||
<location | ||
file="../../../../../../../tests/android/library/src/main/res/values/strings.xml" | ||
line="2" | ||
column="13"/> | ||
</issue> | ||
|
||
<issue | ||
id="MissingApplicationIcon" | ||
message="Should explicitly set `android:icon`, there is no default" | ||
errorLine1=" <application android:label="@string/app_name">" | ||
errorLine2=" ~~~~~~~~~~~"> | ||
<location | ||
file="../../../../../../../tests/android/binary/src/main/AndroidManifest.xml" | ||
line="4" | ||
column="6"/> | ||
</issue> | ||
|
||
</issues> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters