Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change all files to the utf-8 text encoding except *.po #725

Merged
merged 4 commits into from
Oct 9, 2021

Conversation

ndim
Copy link
Member

@ndim ndim commented Oct 5, 2021

This changes all files in the source tree to the utf-8 text encoding. Currently, the source tree contains a mix of UTF-8 and ISO-8859-1 files, as you can check with file, git, and grep:

[user@host libgphoto2]$ file $(git ls-files) | grep 'UTF'
[user@host libgphoto2]$ file $(git ls-files) | grep 'ISO'

This converts the remaining ISO-8859-x files to UTF-8.

@msmeissn
Copy link
Contributor

msmeissn commented Oct 6, 2021

I would not to touch the po files, as we sync them 1:1 from translation project, e.g. they would be overwritten again on next sync. They should be changed on the translationproject side.

ndim added 4 commits October 7, 2021 02:23
Convert the easy ISO-8859 text to UTF-8.

The difficult ISO-8859 text will will be eliminated
by future commits.
I have no idea how that non-ASCII hyphen character made its
way into that m4 file, but this returns a simple ASCII character.
This converts the old camlibs/**/*.txt files from iso-8859-1
to utf-8.
@ndim
Copy link
Member Author

ndim commented Oct 7, 2021

Very good. State of affairs at commit 0f5a9b7:

[user@host libgphoto2]$ file $(git ls-files) | grep 'ISO'
libgphoto2_port/po/de.po:    GNU gettext message catalogue, ISO-8859 text
libgphoto2_port/po/eu.po:    GNU gettext message catalogue, ISO-8859 text
[user@host libgphoto2]$ _

@ndim ndim changed the title change all files to the utf-8 text encoding change all files to the utf-8 text encoding except *.po Oct 8, 2021
@msmeissn msmeissn merged commit f1f09ce into gphoto:master Oct 9, 2021
@ndim ndim deleted the utf-8 branch October 9, 2021 15:05
@ndim
Copy link
Member Author

ndim commented Oct 20, 2021

Out of curiosity in connection with #733, I have taken a look at the Translation Project's status pages for libgphoto2, libgphoto2_port, and gphoto2, and they all list the German de translations as "external", i.e. someone outside the Translation Project handles the de.po files, i.e. there probably are no external submissions of de.po files which we just copy into our source tree verbatim.

Judging from the respective de.po files' headers, @msmeissn was the last translator for gphoto2 and libgphoto2, and from the copyright notices for libgphoto2_port as well.

Of these three, only libgphoto2_port/po/de.po is actually still written in ISO-8859-1, so I will change that to UTF-8 shortly.

This will leave libgphoto2_port/po/eu.po (Basque, last translated for 2.5.27) as the only remaining ISO-8859 po file inside the libgphoto2 repo, and three languages (es fi sk Spanish, Finnish, Slovak, last translated for 2.5.9) for the gphoto2 CLI.

@msmeissn
Copy link
Contributor

yes,m i handle de.po ... feel free to covnert that in *gphoto2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants