blob: permit skipping the configuration of the Content-Disposition header #4832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ader
This change allows users to disable the `Content-Disposition` header that is set for blob storage operations. The application will continue to set a default value for `Content-Disposition` of `attachment; filename={{.Filename}}` if no value was provided by the user. However, with this change, users can now specifically disable this header by setting the value to "-" in the configuration.
We feel this would be a nice solution for this issue: Homebrew/brew#15604
pull-request-size
bot
added
the
size/S
|
this seems like a good compromise, thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4832 +/- ##
==========================================
- Coverage 83.77% 82.78% -1.00%
==========================================
Files 135 139 +4
Lines 13029 11216 -1813
==========================================
- Hits 10915 9285 -1630
+ Misses 1677 1481 -196
- Partials 437 450 +13 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change would allow users to disable the
Content-Dispositionheader that is set for blob storage operations. The application will continue to set a default value forContent-Dispositionofattachment; filename={{.Filename}}if no value was provided by the user. However, with this change, users can now specifically disable this header by setting the value to "-" in the configuration.We feel this would be a nice solution for this issue: Homebrew/brew#15604