-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spx-backend): implement Community API #955
Conversation
c9606dc
to
bd7eb32
Compare
bd7eb32
to
a08b3d4
Compare
a08b3d4
to
df80efe
Compare
df80efe
to
7a503b2
Compare
7a503b2
to
0609f07
Compare
0609f07
to
5271c4e
Compare
5271c4e
to
03c6ea1
Compare
03c6ea1
to
fd28a30
Compare
fd28a30
to
819e924
Compare
@@ -394,7 +390,7 @@ paths: | |||
"204": | |||
description: Successfully deleted the project. | |||
|
|||
/project/liking/{owner}/{name}: | |||
/project/{owner}/{name}/liking: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个改动是不得已的,因为 yap 认为 /project/liking/{owner}/{name}
跟 /project/:owner/:name
冲突(yap 没有细分静态路由和参数路由的优先级)
819e924
to
5bbff67
Compare
@@ -165,13 +165,13 @@ const { | |||
const c = category.value.value | |||
const cPersonal = categoryPersonal.value.value | |||
return listAsset({ | |||
pageSize: 500, // try to get all | |||
pageSize: 100, // try to get all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
后端限制了 pageSize
的值在区间 [1, 100]
。考虑到预期是要做分页的,所以我先遵循 api spec 把这里给改小了。
5bbff67
to
15efafa
Compare
15efafa
to
03232af
Compare
spx-backend/cmd/spx-backend/get_project_#owner_#name_liking.yap
Outdated
Show resolved
Hide resolved
03232af
to
4419a37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其他我没问题了
4419a37
to
862a87c
Compare
Fixes goplus#920 Fixes goplus#948 Signed-off-by: Aofei Sheng <[email protected]>
862a87c
to
8d93319
Compare
This PR has been deployed to the preview environment. You can explore it using the preview URL. Warning Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team. |
补充了测试 & 同步改动了前端,我本地测试了没啥问题,看看还需不需要再 review 下 |
Fixes #920
Fixes #948
Breaking changes to the API spec
Model.cTime
toModel.createdAt
.Model.uTime
toModel.updatedAt
.IsPublic
toVisibility
.Visibility
as a self-descriptive string enum instead of an integer enum.Asset.assetType
toAsset.type
.Asset.type
as a self-descriptive string enum instead of an integer enum./user/following/{username}
to/user/{username}/following
./project/liking/{owner}/{name}
to/project/{owner}/{name}/liking
.requestBody.name
parameter fromPUT /project/{owner}/{name}
.preview
andclickCount
properties fromAsset
.