Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some todos #289

Merged
merged 9 commits into from
Apr 10, 2024
Merged

Fix some todos #289

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5871b91
hooks for file url
nighca Apr 9, 2024
12addf9
disable eslint rule no-redeclare
nighca Apr 9, 2024
ee4a7db
timeout for api client
nighca Apr 9, 2024
dfbf8dc
remove useless TODOs
nighca Apr 9, 2024
a7babcc
remove userInfo assertion in validateName
nighca Apr 9, 2024
b5b7528
keep consistent order for sprites & sounds
nighca Apr 9, 2024
ad3fc85
unit test for filename & sripExt
nighca Apr 9, 2024
89bd40e
typo
nighca Apr 9, 2024
5ed6f86
use file type to construct blob
nighca Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spx-gui/src/models/common/file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class File {
})
const ab = await this.arrayBuffer()
if (cancelled) throw new Cancelled()
const url = URL.createObjectURL(new Blob([ab]))
const url = URL.createObjectURL(new Blob([ab], { type: this.type }))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的this.type我记得不会保存（保存到cloud之后再加载下来type信息会丢失）

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯现在调用上传接口的时候没有把 mime type 提交，这个我单独 PR 解决下吧，得去看下对象存储的接口

onCleanup(() => URL.revokeObjectURL(url))
return url
}
Expand Down
Loading