Skip to content
This repository has been archived by the owner on Dec 15, 2020. It is now read-only.

Disable Website link in the side bar (#66) #67

Merged
merged 2 commits into from
Dec 3, 2019

Conversation

taquitos
Copy link
Contributor

@taquitos taquitos commented Dec 3, 2019

Disable link, but leave plumbing in there so we can update it when we have the new link. #66

Copy link
Contributor

@garrettmurray garrettmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially wrote several comments about changes I'd make, but I think instead I would suggest you simply remove all the .website related code entirely. Just remove the case from AboutRow and the cases from the two switches. It would be trivial to add it back later if they want that functionality, but it would be much cleaner to simply remove it for now.

@taquitos
Copy link
Contributor Author

taquitos commented Dec 3, 2019

@garrettmurray I was thinking about that too, there are translations, and icons too. Thoughts on removing those?

@garrettmurray
Copy link
Contributor

@garrettmurray I was thinking about that too, there are translations, and icons too. Thoughts on removing those?

I think you can leave the icons and translations for now (many of the translated strings might go away long-term anyway). I would just simply remove the logic for now.

science-journal-robot pushed a commit that referenced this pull request Dec 3, 2019
@science-journal-robot science-journal-robot merged commit f0665e7 into master Dec 3, 2019
@taquitos taquitos deleted the web_destination_update branch December 4, 2019 00:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants