This repository has been archived by the owner on Dec 15, 2020. It is now read-only.
Bluetooth unavailable message #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taquitos
requested review from
garrettmurray,
marcisme,
samgrover and
taquitos
garrettmurray
suggested changes
Aug 23, 2019
| @@ -1195,6 +1195,9 @@ | |||
| /* Long description of an unknown bluetooth sensor displayed below a representative image on the Learn More page [CHAR_LIMIT=NONE] */ | |||
| "sensor_desc_second_paragraph_unknown_bluetooth" = "Bluetooth is a wireless technology standard using radio waves to exchange data over short distances from fixed and mobile devices."; | |||
|
|
|||
| /* Message to display to the user when bluetooth is not on but a bluetooth sensor is in the experiment on Observe [CHAR_LIMIT=200] */ | |||
| "bluetooth_not_on_body" = "Cannot connect to external sensor: Bluetooth is disabled. Turn on Bluetooth to connect to your external sensor."; | |||
There was a problem hiding this comment.
Nit: We tend to use _message in the key of strings that will be presented to the user in an alert or snackbar. Can you make the key bluetooth_hardware_disabled_message?
There was a problem hiding this comment.
yes sure will change that.
| @@ -1195,6 +1195,9 @@ | |||
| /* Long description of an unknown bluetooth sensor displayed below a representative image on the Learn More page [CHAR_LIMIT=NONE] */ | |||
| "sensor_desc_second_paragraph_unknown_bluetooth" = "Bluetooth is a wireless technology standard using radio waves to exchange data over short distances from fixed and mobile devices."; | |||
|
|
|||
| /* Message to display to the user when bluetooth is not on but a bluetooth sensor is in the experiment on Observe [CHAR_LIMIT=200] */ | |||
There was a problem hiding this comment.
Just for a bit of clarity, how about:
/* Message to display to the user when Bluetooth is disabled but a Bluetooth sensor is listed in sensor settings because it has been connected in the past.
…of showing bluetooth unavailable message always when the list refreshes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Motivation and Context
been raised an issue on github.
#25
Description
now a snackbar appears on sensor settings view when the bluetooth is not available.
I ran the feature on my device, made sure it works fine.
I ran related tests on Xcode.