Add --tpu-topology flag for specifying custom topology types #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obliviour
force-pushed
the
xpk-tpu-topology
branch
from
3cf2991
to
22fa7d9
Compare
rwitten
approved these changes
Jan 18, 2024
|
The workload creation needs to know the topology as well so CURRENTLY the user needs to set the same topology for workload create and cluster create. This only adds the flag to cluster create. In this case, users would have to manage the topology. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Features
Testing / Documentation
Added a check to make sure the format of topologies fits with the argument expected and the command fails if the format is unexpected.