Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @docImport in webcrypto.dart #175

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Use @docImport in webcrypto.dart #175

merged 1 commit into from
Nov 26, 2024

Conversation

jonasfj
Copy link
Member

@jonasfj jonasfj commented Nov 25, 2024

Introduced in dart-lang/sdk#56186

HamdaanAliQuatil
HamdaanAliQuatil approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@HamdaanAliQuatil HamdaanAliQuatil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ Interesting feature!

Though our use case may not be optimal. We should consider making an issue for this to evaluate more scope for using @docImport in webcrypto.dart

@HamdaanAliQuatil HamdaanAliQuatil merged commit c73702c into google:master Nov 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HamdaanAliQuatil HamdaanAliQuatil HamdaanAliQuatil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonasfj @HamdaanAliQuatil