Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

required result table column #1066

Open
wants to merge 19 commits into
base: feature/384032243-pilot-report
Choose a base branch
from
Open

required result table column #1066

wants to merge 19 commits into from
+200 −106

Conversation

hitnik
Copy link
Collaborator

@hitnik hitnik commented Jan 17, 2025 •
edited
Loading

pilot report example (rename pdf to html)
report.html.pdf

@hitnik hitnik requested a review from sofyakurilova January 17, 2025 15:57
@jboddey
Copy link
Collaborator

jboddey commented Jan 17, 2025

We might as well have the required result column for both pilot and qualification reports. Could you also shift it over to 7in from the left @hitnik?

@MariusBaldovin could you look at fixing the API tests? They shouldn't have broken.

@MariusBaldovin
Copy link
Collaborator

We might as well have the required result column for both pilot and qualification reports. Could you also shift it over to 7in from the left @hitnik?

@MariusBaldovin could you look at fixing the API tests? They shouldn't have broken.

Updated the report

We might as well have the required result column for both pilot and qualification reports. Could you also shift it over to 7in from the left @hitnik?

@MariusBaldovin could you look at fixing the API tests? They shouldn't have broken.

The issue was that the 'test_pack' key was missing in the report used for testing. The report has now been updated.

@sofyakurilova sofyakurilova requested review from jboddey and MariusBaldovin and removed request for sofyakurilova January 21, 2025 12:24
@hitnik
Copy link
Collaborator Author

hitnik commented Jan 21, 2025

@sofyakurilova
report_example.pdf

@sofyakurilova
Adds width for Required result
bb84c93 
Signed-off-by: Sofia Kurilova <[email protected]>
@sofyakurilova
Change display grid
8778fc2 
Signed-off-by: Sofia Kurilova <[email protected]>
@hitnik
Copy link
Collaborator Author

hitnik commented Jan 21, 2025

@sofyakurilova
report_example.pdf

@hitnik
Copy link
Collaborator Author

hitnik commented Jan 21, 2025 •
edited
Loading

report examples
pilot_example_proceed.pdf
device_qual_example_non_comlient.pdf
device_qual_example_complient.pdf
pilot_exmple_do_not_proceed.pdf

@hitnik
Copy link
Collaborator Author

hitnik commented Jan 22, 2025 •
edited
Loading

@OlgaMardvilko
report_example.pdf
report.html.pdf

@hitnik
Copy link
Collaborator Author

hitnik commented Jan 22, 2025

@OlgaMardvilko
report_example.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jboddey jboddey Awaiting requested review from jboddey

@MariusBaldovin MariusBaldovin Awaiting requested review from MariusBaldovin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hitnik @jboddey @MariusBaldovin @sofyakurilova @OlgaMardvilko