Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syz-ci: use random ports for test instances #4829

Merged
merged 1 commit into from
May 22, 2024

Conversation

dvyukov
Copy link
Collaborator

@dvyukov dvyukov commented May 22, 2024

Currently they can collide with the main instance and fail.
Use random ports for test instances.

@dvyukov dvyukov requested a review from a-nogikh May 22, 2024 07:33
@dvyukov dvyukov enabled auto-merge May 22, 2024 07:34
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 61.2%. Comparing base (1014eca) to head (6773f10).

Additional details and impacted files
Files Coverage Δ
syz-ci/syz-ci.go 28.1% <100.0%> (+1.9%) ⬆️
syz-ci/manager.go 5.7% <0.0%> (-<0.1%) ⬇️

... and 2 files with indirect coverage changes

@dvyukov dvyukov force-pushed the dvyukov-fix-syz-ci-test-build branch 2 times, most recently from afc46c4 to 35ff7a1 Compare May 22, 2024 08:22
Currently they can collide with the main instance and fail.
Use unique ports for test instances.
@dvyukov dvyukov force-pushed the dvyukov-fix-syz-ci-test-build branch from 35ff7a1 to 6773f10 Compare May 22, 2024 08:35
@dvyukov dvyukov added this pull request to the merge queue May 22, 2024
Merged via the queue into google:master with commit 4d09803 May 22, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants